Use new ChromeOptions class in specs

Author: p0deje

rb/lib/selenium/webdriver/chrome/driver.rb

@@ -109,7 +109,8 @@ def create_capabilities(opts)
             end
           end
 
-          caps['chromeOptions'] = options.as_json
+          options = options.as_json
+          caps[:chrome_options] = options unless options.empty?
 
           caps[:proxy] = opts.delete(:proxy) if opts.key?(:proxy)
           caps[:proxy] ||= opts.delete('proxy') if opts.key?('proxy')

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

@@ -247,7 +247,9 @@ def create_chrome_driver(opt = {})
           server = ENV['CHROMEDRIVER'] || ENV['chrome_server']
           WebDriver::Chrome.driver_path = server if server
 
-          opt[:args] ||= ENV['TRAVIS'] ? ['--no-sandbox'] : []
+          options = WebDriver::Chrome::Options.new
+          options.add_argument('--no-sandbox') if ENV['TRAVIS']
+          opt[:options] = options
 
           WebDriver::Driver.for :chrome, opt
         end

rb/spec/unit/selenium/webdriver/chrome/driver_spec.rb

@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Chrome
-      describe Driver do
+      fdescribe Driver do
         let(:resp)    { {'sessionId' => 'foo', 'value' => Remote::Capabilities.chrome.as_json} }
         let(:service) { instance_double(Service, start: true, uri: 'http://example.com') }
         let(:caps)    { Remote::Capabilities.new }
@@ -37,7 +37,7 @@ module Chrome
         it 'sets the args capability' do
           Driver.new(http_client: http, args: %w[--foo=bar])
 
-          expect(caps[:chrome_options]['args']).to eq(%w[--foo=bar])
+          expect(caps[:chrome_options][:args]).to eq(%w[--foo=bar])
         end
 
         it 'sets the proxy capabilitiy' do
@@ -57,13 +57,13 @@ module Chrome
         it 'sets the prefs capability' do
           Driver.new(http_client: http, prefs: {foo: 'bar'})
 
-          expect(caps[:chrome_options]['prefs']).to eq(foo: 'bar')
+          expect(caps[:chrome_options][:prefs]).to eq(foo: 'bar')
         end
 
         it 'lets the user override chrome.detach' do
           Driver.new(http_client: http, detach: true)
 
-          expect(caps[:chrome_options]['detach']).to be true
+          expect(caps[:chrome_options][:detach]).to be true
         end
 
         it 'raises an ArgumentError if args is not an Array' do
@@ -79,8 +79,8 @@ module Chrome
           Driver.new(http_client: http, profile: profile)
 
           profile_data = profile.as_json
-          expect(caps[:chrome_options]['args'].first).to include(profile_data[:directory])
-          expect(caps[:chrome_options]['extensions']).to eq(profile_data[:extensions])
+          expect(caps[:chrome_options][:args].first).to include(profile_data[:directory])
+          expect(caps[:chrome_options][:extensions]).to eq(profile_data[:extensions])
         end
 
         it 'takes desired capabilities' do
@@ -100,7 +100,7 @@ module Chrome
           custom_caps[:chrome_options] = {'args' => %w[foo bar]}
 
           expect(http).to receive(:call) do |_, _, payload|
-            expect(payload[:desiredCapabilities][:chrome_options]['args']).to eq(['baz'])
+            expect(payload[:desiredCapabilities][:chrome_options][:args]).to eq(['baz'])
             resp
           end