Skip to content

Commit b6ce2cf

Browse files
committed
Remove hard-coded ports from tests
1 parent ddfcd94 commit b6ce2cf

File tree

3 files changed

+155
-194
lines changed

3 files changed

+155
-194
lines changed

java/test/org/openqa/selenium/firefox/BUILD.bazel

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,16 @@ LARGE_TESTS = [
88
"TakesFullPageScreenshotTest.java",
99
]
1010

11+
REMOTE_TESTS = [
12+
"RemoteFirefoxDriverTest.java",
13+
]
14+
1115
java_test_suite(
1216
name = "small-tests",
1317
size = "small",
1418
srcs = glob(
1519
["*.java"],
16-
exclude = LARGE_TESTS,
20+
exclude = LARGE_TESTS + REMOTE_TESTS,
1721
),
1822
data = [
1923
":firebug_xpi",
@@ -69,6 +73,39 @@ java_selenium_test_suite(
6973
],
7074
)
7175

76+
java_selenium_test_suite(
77+
name = "remote-tests",
78+
size = "large",
79+
srcs = REMOTE_TESTS,
80+
browsers = [
81+
"firefox",
82+
],
83+
data = [
84+
"//third_party/firebug:favourite_colour-1.1-an+fx.xpi",
85+
"//third_party/firebug:firebug-1.5.0-fx.xpi",
86+
"//third_party/firebug:mooltipass-1.1.87.xpi",
87+
],
88+
resources = [
89+
"//third_party/firebug:favourite_colour-1.1-an+fx.xpi",
90+
"//third_party/firebug:firebug-1.5.0-fx.xpi",
91+
"//third_party/firebug:mooltipass-1.1.87.xpi",
92+
],
93+
tags = [
94+
"selenium-remote",
95+
],
96+
deps = [
97+
"//java/src/org/openqa/selenium/firefox",
98+
"//java/src/org/openqa/selenium/remote",
99+
"//java/test/org/openqa/selenium/build",
100+
"//java/test/org/openqa/selenium/testing:annotations",
101+
"//java/test/org/openqa/selenium/testing:test-base",
102+
"//java/test/org/openqa/selenium/testing/drivers",
103+
artifact("junit:junit"),
104+
artifact("org.assertj:assertj-core"),
105+
],
106+
)
107+
108+
72109
copy_file(
73110
name = "firebug_xpi",
74111
src = "//third_party/firebug:firebug-1.5.0-fx.xpi",

0 commit comments

Comments
 (0)