Skip to content

Commit b700761

Browse files
committed
[rb] implement Remote::Driver as a class not a module
1 parent 8981d39 commit b700761

File tree

4 files changed

+14
-94
lines changed

4 files changed

+14
-94
lines changed

rb/lib/selenium/webdriver/remote.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@
2929
require 'selenium/webdriver/remote/capabilities'
3030
require 'selenium/webdriver/remote/oss/bridge'
3131
require 'selenium/webdriver/remote/oss/commands'
32-
require 'selenium/webdriver/remote/oss/driver'
3332

3433
require 'selenium/webdriver/remote/w3c/bridge'
3534
require 'selenium/webdriver/remote/w3c/capabilities'
3635
require 'selenium/webdriver/remote/w3c/commands'
37-
require 'selenium/webdriver/remote/w3c/driver'

rb/lib/selenium/webdriver/remote/driver.rb

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,23 @@ module Remote
2626
# @api private
2727
#
2828

29-
module Driver
29+
class Driver < WebDriver::Driver
30+
include DriverExtensions::UploadsFiles
31+
include DriverExtensions::TakesScreenshot
32+
include DriverExtensions::HasSessionId
33+
include DriverExtensions::Rotatable
34+
include DriverExtensions::HasRemoteStatus
35+
include DriverExtensions::HasWebStorage
3036

31-
def self.new(**opts)
37+
def initialize(opts = {})
3238
listener = opts.delete(:listener)
33-
bridge = Bridge.handshake(opts)
34-
if bridge.dialect == :w3c
35-
W3C::Driver.new(bridge, listener: listener)
36-
else
37-
OSS::Driver.new(bridge, listener: listener)
39+
@bridge = Bridge.handshake(opts)
40+
if @bridge.dialect == :oss
41+
extend DriverExtensions::HasTouchScreen
42+
extend DriverExtensions::HasLocation
43+
extend DriverExtensions::HasNetworkConnection
3844
end
45+
super(@bridge, listener: listener)
3946
end
4047

4148
end # Driver

rb/lib/selenium/webdriver/remote/oss/driver.rb

Lines changed: 0 additions & 44 deletions
This file was deleted.

rb/lib/selenium/webdriver/remote/w3c/driver.rb

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)