Skip to content

Commit db2939c

Browse files
committed
Add guards for mozilla/geckodriver#800
1 parent 39a028e commit db2939c

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

rb/spec/integration/selenium/webdriver/driver_spec.rb

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,14 @@ module WebDriver
3434
expect(driver.page_source).to match(%r{<title>XHTML Test Page</title>}i)
3535
end
3636

37-
not_compliant_on driver: :remote, browser: :phantomjs do
38-
it 'should refresh the page' do
39-
driver.navigate.to url_for('javascriptPage.html')
40-
sleep 1 # javascript takes too long to load
41-
driver.find_element(id: 'updatediv').click
42-
expect(driver.find_element(id: 'dynamo').text).to eq('Fish and chips!')
43-
driver.navigate.refresh
44-
wait_for_element(id: 'dynamo')
45-
expect(driver.find_element(id: 'dynamo').text).to eq("What's for dinner?")
46-
end
37+
it 'should refresh the page', except: {driver: :remote, browser: :phantomjs} do
38+
driver.navigate.to url_for('javascriptPage.html')
39+
sleep 1 # javascript takes too long to load
40+
driver.find_element(id: 'updatediv').click
41+
expect(driver.find_element(id: 'dynamo').text).to eq('Fish and chips!')
42+
driver.navigate.refresh
43+
wait_for_element(id: 'dynamo')
44+
expect(driver.find_element(id: 'dynamo').text).to eq("What's for dinner?")
4745
end
4846

4947
context 'screenshots' do
@@ -277,7 +275,8 @@ def save_screenshot_and_assert(path)
277275
end
278276
end
279277

280-
describe 'execute async script' do
278+
# https://github.com/mozilla/geckodriver/issues/800
279+
describe 'execute async script', except: {browser: :ff_nightly} do
281280
before do
282281
driver.manage.timeouts.script_timeout = 0
283282
driver.navigate.to url_for('ajaxy_page.html')

rb/spec/integration/selenium/webdriver/timeout_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121

2222
module Selenium
2323
module WebDriver
24-
describe Timeouts do
24+
# https://github.com/mozilla/geckodriver/issues/800
25+
describe Timeouts, except: {browser: :ff_nightly} do
2526
context 'implicit waits' do
2627
before do
2728
driver.manage.timeouts.implicit_wait = 0

0 commit comments

Comments
 (0)