Skip to content

Commit e804d9b

Browse files
abotalovandreastt
authored andcommitted
Remove dead browser visible methods
Signed-off-by: Andreas Tolfsen <ato@mozilla.com>
1 parent fceda53 commit e804d9b

File tree

6 files changed

+0
-32
lines changed

6 files changed

+0
-32
lines changed

java/client/src/org/openqa/selenium/remote/DriverCommand.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ public interface DriverCommand {
7575
String EXECUTE_SCRIPT = "executeScript";
7676
String EXECUTE_ASYNC_SCRIPT = "executeAsyncScript";
7777

78-
String SET_BROWSER_VISIBLE = "setBrowserVisible";
79-
String IS_BROWSER_VISIBLE = "isBrowserVisible";
80-
8178
String GET_ELEMENT_TEXT = "getElementText";
8279
String GET_ELEMENT_VALUE = "getElementValue";
8380
String GET_ELEMENT_TAG_NAME = "getElementTagName";

java/client/src/org/openqa/selenium/remote/HttpCommandExecutor.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,6 @@ public HttpCommandExecutor(Map<String, CommandInfo> additionalCommands, URL addr
147147
.put(GET_TITLE, get("/session/:sessionId/title"))
148148
.put(GET_PAGE_SOURCE, get("/session/:sessionId/source"))
149149
.put(SCREENSHOT, get("/session/:sessionId/screenshot"))
150-
.put(SET_BROWSER_VISIBLE, post("/session/:sessionId/visible"))
151-
.put(IS_BROWSER_VISIBLE, get("/session/:sessionId/visible"))
152150
.put(FIND_ELEMENT, post("/session/:sessionId/element"))
153151
.put(FIND_ELEMENTS, post("/session/:sessionId/elements"))
154152
.put(GET_ACTIVE_ELEMENT, post("/session/:sessionId/element/active"))

py/selenium/webdriver/remote/command.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ class Command(object):
6565
GET_PAGE_SOURCE = "getPageSource"
6666
GET_TITLE = "getTitle"
6767
EXECUTE_SCRIPT = "executeScript"
68-
SET_BROWSER_VISIBLE = "setBrowserVisible"
69-
IS_BROWSER_VISIBLE = "isBrowserVisible"
7068
GET_ELEMENT_TEXT = "getElementText"
7169
GET_ELEMENT_VALUE = "getElementValue"
7270
GET_ELEMENT_TAG_NAME = "getElementTagName"

py/selenium/webdriver/remote/remote_connection.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,6 @@ def __init__(self, remote_server_addr, keep_alive=False):
175175
Command.GET_TITLE: ('GET', '/session/$sessionId/title'),
176176
Command.GET_PAGE_SOURCE: ('GET', '/session/$sessionId/source'),
177177
Command.SCREENSHOT: ('GET', '/session/$sessionId/screenshot'),
178-
Command.SET_BROWSER_VISIBLE:
179-
('POST', '/session/$sessionId/visible'),
180-
Command.IS_BROWSER_VISIBLE: ('GET', '/session/$sessionId/visible'),
181178
Command.FIND_ELEMENT: ('POST', '/session/$sessionId/element'),
182179
Command.FIND_ELEMENTS: ('POST', '/session/$sessionId/elements'),
183180
Command.GET_ACTIVE_ELEMENT:

rb/lib/selenium/webdriver/common/driver.rb

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -140,26 +140,6 @@ def page_source
140140
bridge.getPageSource
141141
end
142142

143-
#
144-
# Get the visibility of the browser. Not applicable for all browsers.
145-
#
146-
# @return [Boolean]
147-
#
148-
149-
def visible?
150-
bridge.getBrowserVisible
151-
end
152-
153-
#
154-
# Set the visibility of the browser. Not applicable for all browsers.
155-
#
156-
# @param [Boolean]
157-
#
158-
159-
def visible=(bool)
160-
bridge.setBrowserVisible bool
161-
end
162-
163143
#
164144
# Quit the browser
165145
#

rb/lib/selenium/webdriver/remote/commands.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ class Selenium::WebDriver::Remote::Bridge
2020
command :refresh, :post, "session/:session_id/refresh"
2121
command :quit, :delete, "session/:session_id"
2222
command :close, :delete, "session/:session_id/window"
23-
command :getVisible, :get, "session/:session_id/visible"
24-
command :setVisible, :post, "session/:session_id/visible"
2523
command :getPageSource, :get, "session/:session_id/source"
2624
command :getTitle, :get, "session/:session_id/title"
2725
command :findElement, :post, "session/:session_id/element"

0 commit comments

Comments
 (0)