Skip to content

Commit fb6065f

Browse files
committed
Changing .NET WebDriverBackedSelenium OpenWindow to mimic Java.
The JavaScript evaluated by the .NET WebDriverBackedSelenium OpenWindow command handler should return a null value from the eval() of the JavaScript to open the window. This is what the Java implementation does, and this commit brings the .NET implementation into line with that. Fixes issue #6966.
1 parent d791a48 commit fb6065f

File tree

1 file changed

+1
-1
lines changed
  • dotnet/src/webdriverbackedselenium/Internal/SeleniumEmulation

1 file changed

+1
-1
lines changed

dotnet/src/webdriverbackedselenium/Internal/SeleniumEmulation/OpenWindow.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public OpenWindow(GetEval windowOpener)
3131
/// <returns>The result of the command.</returns>
3232
protected override object HandleSeleneseCommand(IWebDriver driver, string locator, string value)
3333
{
34-
string[] args = { string.Format(CultureInfo.InvariantCulture, "window.open('{0}', '{1}');", locator, value) };
34+
string[] args = { string.Format(CultureInfo.InvariantCulture, "window.open('{0}', '{1}'); null;", locator, value) };
3535

3636
this.opener.Apply(driver, args);
3737

0 commit comments

Comments
 (0)