Skip to content

On Windows, RemoteWebDriver.quit() is always destroying forcefully? #614

@benlei-neustar

Description

@benlei-neustar

I'm constantly receiving the below log output:
INFO 06/04 22:43:04 o.o.s.o.UnixProcess - Command failed to close cleanly. Destroying forcefully (v2). org.openqa.selenium.os.UnixProcess$SeleniumWatchDog@6527b9ac

This happens whenever I do a driver.quit() (which is a RemoteWebDriver). This problem is not showing with Selenium 2.45.0.

This will stop the output from happening, but I am not sure if this is the right way to go:

diff --git a/java/client/src/org/openqa/selenium/os/UnixProcess.java b/java/client/src/org/openqa/selenium/os/UnixProcess.java
index cd7af38..47d6575 100644
--- a/java/client/src/org/openqa/selenium/os/UnixProcess.java
+++ b/java/client/src/org/openqa/selenium/os/UnixProcess.java
@@ -119,9 +119,12 @@ public int destroy() {
       if (!isRunning()) {
         return getExitCode();
       }
+
+      watchdog.destroyHarder();
+    } else {
+      watchdog.destroy(); // don't want the error message
     }

-    watchdog.destroyHarder();
     watchdog.waitForTerminationAfterDestroy(1, SECONDS);
     if (!isRunning()) {
       return getExitCode();
@@ -244,6 +247,10 @@ private void waitForTerminationAfterDestroy(int duration, TimeUnit unit) {

     private void destroyHarder() {
       log.info("Command failed to close cleanly. Destroying forcefully (v2). " + this);
+      destroy();
+    }
+
+    private void destroy() {
       Process ourProc = process;
       ProcessUtils.killProcess(ourProc);
     }

the post that introduced the plugin container fix: https://code.google.com/p/selenium/issues/detail?id=7506

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions