Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#676 reply to new/reopened ticket only if author != self #677

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

amihaiemil
Copy link
Member

Fixes #676
If the PM is the author of a new or reopened ticket, it should not reply to itself.

@charlesmike
Copy link

@amihaiemil thank you for your Pull Request. I'll assign someone to review it soon.

@amihaiemil
Copy link
Member Author

@rultor merge it please

@rultor
Copy link
Collaborator

rultor commented Nov 9, 2020

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@charlesmike
Copy link

@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2020-11-12T14:57:23.055998.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@rultor
Copy link
Collaborator

rultor commented Nov 9, 2020

@rultor merge it please

@amihaiemil Oops, I failed. You can see the full log here (spent 3min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 849
+ echo '1.69.1 839260fab'
1.69.1 839260fab
+ date
Mon Nov  9 13:57:36 CET 2020
+ uptime
 13:57:36 up 42 days, 23:03,  0 users,  load average: 0.07, 0.08, 0.02
+ ff=default
+ image=g4s8/rultor-jdk11:alpine3.10
+ rebase=false
+ head_branch=master
+ pull_title='#676 reply to new/reopened ticket only if author != self'
+ author=amihaiemil
+ directory=
+ head=git@github.com:self-xdsd/self-core.git
+ pull_id=677
+ fork=git@github.com:amihaiemil/self-core.git
+ fork_branch=676
+ squash=false
+ vars=('--env=JAVA_HOME=/usr/lib/jvm/java-11-openjdk' '--env=head=git@github.com:self-xdsd/self-core.git' '--env=pull_id=677' '--env=fork=git@github.com:amihaiemil/self-core.git' '--env=fork_branch=676' '--env=head_branch=master' '--env=pull_title=#676 reply to new/reopened ticket only if author != self' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:self-xdsd/self-core.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=677'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:amihaiemil/self-core.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=676'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#676 reply to new/reopened ticket only if author != self'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle,itcases'\'' '\'';'\'' )')
+ scripts=('export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ';' 'export '\''head=git@github.com:self-xdsd/self-core.git'\''' ';' 'export '\''pull_id=677'\''' ';' 'export '\''fork=git@github.com:amihaiemil/self-core.git'\''' ';' 'export '\''fork_branch=676'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#676 reply to new/reopened ticket only if author != self'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle,itcases' ';')
+ container=self-xdsd_self-core_677
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:self-xdsd/self-core.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ';' 'export '\''head=git@github.com:self-xdsd/self-core.git'\''' ';' 'export '\''pull_id=677'\''' ';' 'export '\''fork=git@github.com:amihaiemil/self-core.git'\''' ';' 'export '\''fork_branch=676'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#676 reply to new/reopened ticket only if author != self'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle,itcases' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
'cid' file is absent, container wasn't started correctly

@amihaiemil amihaiemil merged commit b62e37e into self-xdsd:master Nov 9, 2020
@amihaiemil amihaiemil deleted the 676 branch November 9, 2020 13:00
@charlesmike
Copy link

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Reply If Issue/PR Author is Self
3 participants