The icon path should be prefixed with the destination path. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PATCH applied to fix this:
diff --git a/html2dash.py b/html2dash.py
index b8d341d..ed0259a 100755
--- a/html2dash.py
+++ b/html2dash.py
@@ -116,7 +116,7 @@ if __name__ == "__main__":
# create docset directory and copy files
doc_path = docset_name + "/Contents/Resources/Documents"
dsidx_path = docset_name + "/Contents/Resources/docSet.dsidx"
- icon_path = docset_name + "/icon.png"
+ icon = docset_name + "/icon.png"
info = docset_name + "/Contents/info.plist"
destpath = results.path
@@ -125,6 +125,7 @@ if __name__ == "__main__":
docset_path = destpath + doc_path
sqlite_path = destpath + dsidx_path
info_path = destpath + info
+ icon_path = destpath + icon
# print docset_path, sqlite_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom icon is used, the script (html2dash.py) is unable to copy the icon into the given destination path.
This is fixed by prefixing the icon path with the destination (it also makes it conform to the existing code-style, where other paths have been prefixed with the destination).
The open issue regarding this: #9