Linux appimage wdio #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions on select-devices)
…d have 22.03.0 release on file system
…d have 22.03.0 release on file system II
…70 Bytes) is so small that is an issue on test
…ll (70 Bytes) that make an issue
… CheckResourcesOfficialRelease pages; added test for checking the already downloaded signature file
…udex's ktool tests isolated
…ts); added support to maixpy_dock (-dan option on flash); fixed many tests
I) removed oldest firmwares options II) firmwares to choose will be only the latest official and odudex krux_binaries III) improved tests IV) added support to maixpy_dock (-dan option on flash) V) using electron 24.1.2
odudex
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
I'm not qualified to inspect the code details, but the project seems very well structured. I tested both Linux and Windows installers with different target devices and it worked flawlessly. This is awesome for the project! Congratulations and thank you for your work!
jdlcdl
pushed a commit
to jdlcdl/krux-installer
that referenced
this pull request
Aug 23, 2024
fixed patch-win task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has some major updates:
I) Running on electron 24.1.2
II) Added support for
maixpy_dockdevice (many thanks to @tadeubas for finding the problem and @odudex for for indicating the solution);III) Added automated E2E tests with webdriver.io;
IV) Improved pipeline (lint, build, test, upload artifacts) on github-actions;
V) All updates are for
AppImagefor Linux andNSISInstaller setup for Windows;Minor updates:
I) Update many packages that was flagged with vulnerabilities by dependabot;
II) a timeout between check and download pages;
III) only the latest official version of krux's firmware and test version of @odudex firmware are listed on
Select Versionbuttons (@odudex and @tadeubas suggestion);IV) showing the complete command to users on binary verification and flashing process;