Add ability to supply a dataset name to xport library. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selik
requested changes
Jan 30, 2018
| @@ -163,7 +163,9 @@ def __init__(self, fp): | |||
| self.created = created | |||
| self.modified = modified | |||
|
|
|||
| namestr_size = self._read_member_header()[-1] | |||
| dsname, _, dslabel, _, _, _, _, namestr_size = self._read_member_header() | |||
| self.dsname = dsname | |||
There was a problem hiding this comment.
I'm not sure that dsname and dslabel are the best attribute names. Regardless of whether you can come up with something better, do you mind adding a change to the README to explain these?
Another option is making them properties to allow a docstring for them separate from the class.
| @@ -597,7 +599,7 @@ def from_columns(mapping, fp): | |||
|
|
|||
| # make a copy to avoid accidentally mutating the passed-in data | |||
| columns = OrderedDict((k, list(v)) for k, v in mapping.items()) | |||
|
|
|||
| dataset_name_binary = dataset_name.encode('ascii').ljust(8) | |||
There was a problem hiding this comment.
What happens if the dataset name is longer than 8 characters?
|
Sorry I didn't get around to this for so long @dsgoldberg . I merged a big change (#34) which adds this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #14 - currently the dataset name defaults to 'dataset'.
This pull request adds an optional variable of dataset_name to the from_* functions so that you can provide a dataset_name if needed.