#9 - Add support to delete publishers and subscribers from the graph #41
Conversation
There was a problem hiding this comment.
Great work mate! For a complete newbie you've written some pretty idiomatic looking code.
I'm going to have a go tomorrow at refactoring your _rm_left_leaf into a single loop that recurses up the tree, deleting as it goes. We should also consider that the graph is 'live', meaning that data is flowing 'through' it while we're mutating it. I didn't put this as an acceptance criteria (sorry my bad) but we should try and isolate the branch to be deleted before operating on it.
I'll have a go at this tomorrow and then do a code review with you when I'm finished. Feel free to make the other refactoring changes in the interim.
Again, great work mate! Rust is a really tough language and you've already produced a great changeset, with tests! 🥳
No description provided.