feat: migrate from travis_after_all to travis-after-all

`travis_after_all` is a python script that had to be added to .travis.yml
manually to support testing multiple node versions. `travis-after-all` is the
same thing (even better actually, as it supports "allowed-failures") and can
be required. This is now part of this verification plugin.

You may now happily apply this patch to your `.travis.yml`. (It keeps working
if you leave in, so this isn't even breaking 😱)

```diff
---
 .travis.yml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index a5fbddb..c76091b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,9 +14,6 @@ before_install:
 - npm i -g npm@^2.0.0
 before_script:
 - npm prune
-- curl -Lo travis_after_all.py https://git.io/vLSON
 after_success:
-- python travis_after_all.py
-- export $(cat .to_export_back)
 - npm run semantic-release
--
```

Author: boennemann

package.json

@@ -14,13 +14,15 @@
     }
   },
   "dependencies": {
-    "@semantic-release/error": "^1.0.0"
+    "@semantic-release/error": "^1.0.0",
+    "travis-after-all": "^1.3.0"
   },
   "devDependencies": {
     "babel": "^5.5.8",
     "coveralls": "^2.11.2",
     "mkdirp": "^0.5.1",
     "nyc": "^3.0.0",
+    "proxyquire": "^1.7.1",
     "rimraf": "^2.4.0",
     "semantic-release": "^5.0.1",
     "standard": "^5.1.0",

src/index.js

@@ -1,4 +1,4 @@
-const { unlinkSync } = require('fs')
+const travisAfterAll = require('travis-after-all')
 
 const SRError = require('@semantic-release/error')
 
@@ -10,14 +10,13 @@ module.exports = function (pluginConfig, {env, options}, cb) {
 
   if (options.branch !== env.TRAVIS_BRANCH) return cb(new SRError(`Branch is not ${options.branch}`, 'EBRANCHMISMATCH'))
 
-  if (env.BUILD_MINION === 'YES') return cb(new SRError('Not publishing from minion', 'ENOBUILDLEADER'))
+  travisAfterAll((code, err) => {
+    if (code === 0) return cb(null)
 
-  if (env.BUILD_LEADER === 'YES') {
-    if (env.BUILD_AGGREGATE_STATUS !== 'others_succeeded') return cb(new SRError('Not publishing when other jobs in the build matrix fail.', 'EOTHERSFAILED'))
+    if (code === 1) return cb(new SRError('Not publishing when other jobs in the build matrix fail.', 'EOTHERSFAILED'))
 
-    try { unlinkSync('./travis_after_all.py') } catch (e) {}
-    try { unlinkSync('./.to_export_back') } catch (e) {}
-  }
+    if (code === 2) return cb(new SRError('Not publishing from minion', 'ENOBUILDLEADER'))
 
-  cb(null)
+    cb(err || new SRError('travis-after-all return unexpected error code', 'ETAAFAIL'))
+  })
 }

test/specs/index.js

@@ -1,7 +1,10 @@
+const proxyquire = require('proxyquire')
 const { test } = require('tap')
 const SRError = require('@semantic-release/error')
 
-const condition = require('../../dist')
+const condition = proxyquire('../../', {
+  'travis-after-all': (cb) => cb(0)
+})
 
 test('raise errors in travis environment', (t) => {
   t.test('only runs on travis', (tt) => {
@@ -82,15 +85,15 @@ test('raise errors in travis environment', (t) => {
     })
   })
 
-  t.test('supports travis_after_all', (tt) => {
-    tt.plan(5)
+  t.test('supports travis-after-all', (tt) => {
+    tt.plan(8)
 
-    condition({}, {
+    proxyquire('../../', {
+      'travis-after-all': (cb) => cb(0)
+    })({}, {
       env: {
         TRAVIS: 'true',
-        TRAVIS_BRANCH: 'master',
-        BUILD_LEADER: 'YES',
-        BUILD_AGGREGATE_STATUS: 'others_succeeded'
+        TRAVIS_BRANCH: 'master'
       },
       options: {
         branch: 'master'
@@ -99,11 +102,12 @@ test('raise errors in travis environment', (t) => {
       tt.is(err, null)
     })
 
-    condition({}, {
+    proxyquire('../../', {
+      'travis-after-all': (cb) => cb(2)
+    })({}, {
       env: {
         TRAVIS: 'true',
-        TRAVIS_BRANCH: 'master',
-        BUILD_MINION: 'YES'
+        TRAVIS_BRANCH: 'master'
       },
       options: {
         branch: 'master'
@@ -113,12 +117,12 @@ test('raise errors in travis environment', (t) => {
       tt.is(err.code, 'ENOBUILDLEADER')
     })
 
-    condition({}, {
+    proxyquire('../../', {
+      'travis-after-all': (cb) => cb(1)
+    })({}, {
       env: {
         TRAVIS: 'true',
-        TRAVIS_BRANCH: 'master',
-        BUILD_LEADER: 'YES',
-        BUILD_AGGREGATE_STATUS: 'others_failed'
+        TRAVIS_BRANCH: 'master'
       },
       options: {
         branch: 'master'
@@ -127,5 +131,35 @@ test('raise errors in travis environment', (t) => {
       tt.ok(err instanceof SRError)
       tt.is(err.code, 'EOTHERSFAILED')
     })
+
+    proxyquire('../../', {
+      'travis-after-all': (cb) => cb('weird?')
+    })({}, {
+      env: {
+        TRAVIS: 'true',
+        TRAVIS_BRANCH: 'master'
+      },
+      options: {
+        branch: 'master'
+      }
+    }, (err) => {
+      tt.ok(err instanceof SRError)
+      tt.is(err.code, 'ETAAFAIL')
+    })
+
+    var error = {}
+    proxyquire('../../', {
+      'travis-after-all': (cb) => cb(null, error)
+    })({}, {
+      env: {
+        TRAVIS: 'true',
+        TRAVIS_BRANCH: 'master'
+      },
+      options: {
+        branch: 'master'
+      }
+    }, (err) => {
+      tt.is(err, error)
+    })
   })
 })