Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote changes from beta to main #483

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Promote changes from beta to main #483

merged 3 commits into from
Jan 27, 2023

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Jan 18, 2023 •
edited
Loading

🛑 Don't squash when merging

@fgreinacher
feat: convert package to ESM (#464)
3b11f00 
BREAKING CHANGE: This package is now ESM-only and cannot be used by CJS packages.

BREAKING CHANGE: The minimum supported Node version has been changed to 18.0.0.
@fgreinacher fgreinacher self-assigned this Jan 18, 2023
@fgreinacher fgreinacher changed the title feat: convert package to ESM (#464) Promote changes from beta to main Jan 18, 2023
@travi
Copy link
Member

travi commented Jan 25, 2023

support for loading ESM plugins has been backported to the current stable channel in https://github.com/semantic-release/semantic-release/releases/tag/v20.1.0. i'd suggest trying out your beta with that version, but without any surprises, i expect that blocker to be solved.

travi
travi reviewed Jan 25, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@fgreinacher
chore: require semantic-release >=20.1.0
f3444fa 
BREAKING CHANGE: The plugin is not compatible with semantic-release < 20.1.0
@fgreinacher
Copy link
Contributor Author

support for loading ESM plugins has been backported to the current stable channel in https://github.com/semantic-release/semantic-release/releases/tag/v20.1.0. i'd suggest trying out your beta with that version, but without any surprises, i expect that blocker to be solved.

Yes, works perfectly with semantic-release@20.1.0 and the @semantic-release/gitlab@10.0.0-beta.2: https://gitlab.com/fgreinacher/semantic-release-test/-/jobs/3666245807

@fgreinacher fgreinacher marked this pull request as ready for review January 26, 2023 15:38
travi
travi approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚀

@fgreinacher fgreinacher merged commit e7ce1a5 into master Jan 27, 2023
@fgreinacher fgreinacher deleted the beta branch January 27, 2023 05:05
@github-actions
Copy link

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travi travi travi approved these changes

Assignees

@fgreinacher fgreinacher

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgreinacher @travi