fix: properly handle completely unpublished packages (#113)

Author: vovacodes

src/index.js

@@ -12,28 +12,29 @@ module.exports = function (pluginConfig, {pkg, npm, plugins, options}, cb) {
   client.get(`${npm.registry}${pkg.name.replace('/', '%2F')}`, {
     auth: npm.auth
   }, (err, data) => {
-    if (err && (
-      err.statusCode === 404 ||
-      /not found/i.test(err.message)
-    )) {
+    const isNotFound = err && (err.statusCode === 404 || /not found/i.test(err.message))
+    const isCompletelyUnpublished = data && !data['dist-tags']
+
+    if (isNotFound || isCompletelyUnpublished) {
       return cb(null, {})
     }
 
     if (err) return cb(err)
 
-    let version = data['dist-tags'][npm.tag]
+    const distTags = data['dist-tags']
+    let version = distTags[npm.tag]
 
     if (!version &&
       options &&
       options.fallbackTags &&
       options.fallbackTags[npm.tag] &&
-      data['dist-tags'][options.fallbackTags[npm.tag]]) {
-      version = data['dist-tags'][options.fallbackTags[npm.tag]]
+      distTags[options.fallbackTags[npm.tag]]) {
+      version = distTags[options.fallbackTags[npm.tag]]
     }
 
     if (!version) {
       return cb(new SemanticReleaseError(
-`There is no release with the dist-tag "${npm.tag}" yet.
+        `There is no release with the dist-tag "${npm.tag}" yet.
 Tag a version manually or define "fallbackTags".`, 'ENODISTTAG'))
     }
 

test/mocks/registry.js

@@ -15,6 +15,16 @@ const availableModule = {
   }
 }
 
+const completelyUnpublishedModule = {
+  name: 'i-am-completely-unpublished',
+  time: {
+    '2.0.0': '2016-12-01T17:50:30.699Z',
+    unpublished: {
+      time: '2016-12-01T17:53:45.940Z'
+    }
+  }
+}
+
 module.exports = nock('http://registry.npmjs.org')
   .get('/available')
   .reply(200, availableModule)
@@ -25,6 +35,8 @@ module.exports = nock('http://registry.npmjs.org')
   .reply(200, availableModule)
   .get('/@scoped%2Favailable')
   .reply(200, availableModule)
+  .get('/completely-unpublished')
+  .reply(200, completelyUnpublishedModule)
   .get('/unavailable')
   .reply(404, {})
   .get('/unavailable-no-body')

test/specs/index.js

@@ -11,7 +11,7 @@ const npm = {
 }
 
 test('last release from registry', (t) => {
-  t.plan(6)
+  t.plan(7)
 
   t.test('get release from package name', (tt) => {
     lastRelease({}, {
@@ -85,6 +85,17 @@ test('last release from registry', (t) => {
     })
   })
 
+  t.test('get nothing from completely unpublished package name', (tt) => {
+    lastRelease({}, {
+      pkg: {name: 'completely-unpublished'},
+      npm
+    }, (err, release) => {
+      tt.error(err)
+      tt.is(release.version, undefined, 'no version')
+      tt.end()
+    })
+  })
+
   t.test('get nothing from not yet published package name', (tt) => {
     tt.plan(3)