Skip to content

Commit 22d391d

Browse files
committed
refactor: use ethers conditional exports
re #632
1 parent 169445a commit 22d391d

File tree

9 files changed

+17
-16
lines changed

9 files changed

+17
-16
lines changed

packages/data/src/ethers.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1+
import { ZeroAddress } from "ethers/constants"
2+
import { Contract } from "ethers/contract"
13
import {
24
AlchemyProvider,
35
AnkrProvider,
46
CloudflareProvider,
5-
Contract,
67
EtherscanProvider,
78
InfuraProvider,
89
JsonRpcProvider,
910
PocketProvider,
10-
Provider,
11-
ZeroAddress
12-
} from "ethers"
11+
Provider
12+
} from "ethers/providers"
1313
import checkParameter from "./checkParameter"
1414
import getEvents from "./getEvents"
1515
import SemaphoreABI from "./semaphoreABI.json"

packages/data/src/getEvents.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* istanbul ignore file */
2-
import { Contract, EventLog } from "ethers"
2+
import { Contract, EventLog } from "ethers/contract"
33

44
/**
55
* Returns the list of events of a contract with possible filters.

packages/data/tests/ethers.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/* eslint-disable no-sparse-arrays */
2-
import { Contract, ZeroAddress } from "ethers"
2+
import { ZeroAddress } from "ethers/constants"
3+
import { Contract } from "ethers/contract"
34
import SemaphoreEthers from "../src/ethers"
45
import getEvents from "../src/getEvents"
56

@@ -8,9 +9,9 @@ jest.mock("../src/getEvents", () => ({
89
default: jest.fn()
910
}))
1011

11-
jest.mock("ethers", () => ({
12+
jest.mock("ethers/contract", () => ({
1213
__esModule: true,
13-
...jest.requireActual("ethers"),
14+
...jest.requireActual("ethers/contract"),
1415
Contract: jest.fn(
1516
() =>
1617
({

packages/data/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"extends": "../../tsconfig.json",
3-
"include": ["src", "rollup.config.ts"]
3+
"include": ["src", "tests", "rollup.config.ts"]
44
}

packages/proof/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
"access": "public"
3939
},
4040
"devDependencies": {
41-
"@ethersproject/strings": "^5.7.0",
4241
"@rollup/plugin-alias": "^5.1.0",
4342
"@rollup/plugin-json": "^6.1.0",
4443
"@types/download": "^8.0.5",

packages/proof/src/generate-proof.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ export default async function generateProof(
4848
}
4949

5050
// If the Snark artifacts are not defined they will be automatically downloaded.
51-
/* istanbul ignore next */
5251
if (!snarkArtifacts) {
5352
snarkArtifacts = await getSnarkArtifacts(merkleTreeDepth)
5453
}

packages/proof/src/hash.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { keccak256, toBeHex } from "ethers"
1+
import { keccak256 } from "ethers/crypto"
2+
import { toBeHex } from "ethers/utils"
23
import { NumericString } from "snarkjs"
34
import { BigNumberish } from "./types"
45

packages/proof/src/to-bigint.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { encodeBytes32String, toBigInt as _toBigInt } from "ethers"
1+
import { encodeBytes32String } from "ethers/abi"
2+
import { toBigInt as _toBigInt } from "ethers/utils"
23
import { BigNumberish } from "./types"
34

45
export default function toBigInt(value: BigNumberish | Uint8Array | string): bigint {

tsconfig.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"baseUrl": ".",
44
"strict": true,
55
"target": "ES5",
6-
"module": "ES6",
7-
"moduleResolution": "node",
6+
"module": "ESNext",
7+
"moduleResolution": "Bundler",
88
"esModuleInterop": true,
99
"preserveConstEnums": true,
1010
"resolveJsonModule": true,
@@ -14,7 +14,7 @@
1414
"declarationDir": "types",
1515
"typeRoots": ["node_modules/@types", "types"],
1616
"paths": {
17-
"@semaphore-protocol/*": ["packages/*/src"]
17+
"@semaphore-protocol/*": ["./packages/*/src"]
1818
}
1919
},
2020
"ts-node": {

0 commit comments

Comments
 (0)