fix(group): add check for zero values in group constructor (#764)

Author: cedoor

packages/group/src/index.ts

@@ -23,6 +23,12 @@ export class Group {
      * @param members A list of identity commitments.
      */
     constructor(members: BigNumber[] = []) {
+        for (const member of members) {
+            if (member === 0n || member === "0") {
+                throw new Error("Failed to add member: value cannot be 0")
+            }
+        }
+
         this.leanIMT = new LeanIMT((a, b) => poseidon2([a, b]), members.map(BigInt))
     }
 

packages/group/tests/index.test.ts

@@ -23,6 +23,12 @@ describe("Group", () => {
             expect(group.depth).toBe(2)
             expect(group.size).toBe(3)
         })
+
+        it("Should not create a group with a list of members if any value is 0", () => {
+            const fun = () => new Group([1n, 0n])
+
+            expect(fun).toThrow("Failed to add member: value cannot be 0")
+        })
     })
 
     describe("# addMember", () => {