refactor(contracts): optimize gas

vplasencia · vplasencia · commit b0f40ef5c938 · 2024-01-16T17:54:37.000+01:00
diff --git a/packages/contracts/contracts/base/SemaphoreGroups.sol b/packages/contracts/contracts/base/SemaphoreGroups.sol
@@ -68,8 +68,8 @@ abstract contract SemaphoreGroups is ISemaphoreGroups {
         uint256 groupId,
         uint256 identityCommitment
     ) internal virtual onlyExistingGroup(groupId) onlyGroupAdmin(groupId) {
+        uint256 leafIndex = getMerkleTreeSize(groupId);
         uint256 merkleTreeRoot = merkleTrees[groupId]._insert(identityCommitment);
-        uint256 leafIndex = getMerkleTreeSize(groupId) - 1;
 
         emit MemberAdded(groupId, leafIndex, identityCommitment, merkleTreeRoot);
     }

Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,8 @@ abstract contract SemaphoreGroups is ISemaphoreGroups {`
`68`	`68`	`uint256 groupId,`
`69`	`69`	`uint256 identityCommitment`
`70`	`70`	`) internal virtual onlyExistingGroup(groupId) onlyGroupAdmin(groupId) {`
	`71`	`+ uint256 leafIndex = getMerkleTreeSize(groupId);`
`71`	`72`	`uint256 merkleTreeRoot = merkleTrees[groupId]._insert(identityCommitment);`
`72`		`- uint256 leafIndex = getMerkleTreeSize(groupId) - 1;`
`73`	`73`
`74`	`74`	`emit MemberAdded(groupId, leafIndex, identityCommitment, merkleTreeRoot);`
`75`	`75`	`}`