Skip to content

Commit bb0b58e

Browse files
vplasenciacedoor
authored andcommitted
perf(cli): optimize get-members command
1 parent 93e4a5d commit bb0b58e

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

packages/cli/src/index.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ program
192192
groupId = await getGroupId(groupIds)
193193
}
194194

195-
let group: GroupResponse
195+
let groupMembers: string[]
196196

197197
const spinner = new Spinner(`Fetching members of group ${groupId}`)
198198

@@ -201,16 +201,15 @@ program
201201
try {
202202
const semaphoreSubgraph = new SemaphoreSubgraph(network)
203203

204-
group = await semaphoreSubgraph.getGroup(groupId, { members: true })
204+
const group = await semaphoreSubgraph.getGroup(groupId, { members: true })
205+
groupMembers = group.members
205206

206207
spinner.stop()
207208
} catch {
208209
try {
209210
const semaphoreEthers = new SemaphoreEthers(network)
210211

211-
group = await semaphoreEthers.getGroup(groupId)
212-
213-
group.members = await semaphoreEthers.getGroupMembers(groupId)
212+
groupMembers = await semaphoreEthers.getGroupMembers(groupId)
214213

215214
spinner.stop()
216215
} catch {
@@ -220,12 +219,12 @@ program
220219
}
221220
}
222221

223-
if (group.members.length === 0) {
222+
if (groupMembers.length === 0) {
224223
console.info(`\n ${logSymbols.info}`, "info: there are no members in this group\n")
225224
return
226225
}
227226

228-
const content = `${chalk.bold("Members")}: \n${group.members
227+
const content = `${chalk.bold("Members")}: \n${groupMembers
229228
.map((member: string, i: number) => ` ${i}. ${member}`)
230229
.join("\n")}`
231230

0 commit comments

Comments
 (0)