Allow SEMAPHORE_AGENT_LOG_FILE_PATH to be specified #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogyo210
reviewed
Feb 22, 2022
| } | ||
|
|
||
| parentDirectory := path.Dir(logFilePath) | ||
| err := os.MkdirAll(parentDirectory, 0644) |
There was a problem hiding this comment.
Just for me to know: does this create a directory structure or just one directory?
There was a problem hiding this comment.
a directory structure: https://pkg.go.dev/os#MkdirAll
shiroyasha
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker_private_image_ecrE2E test was disabled because the AWS credentials required by it are not working anymore. The test has been failing for almost a month.Once they are working again, we can enable this test again.