Handle secrets without contents #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ask before opening editor for secrets that get replaced * Fix segfault when casting nil * Different way of asking for confirmation * Ask for secret name instead of just y/n to confirm update action
lucaspin
reviewed
Jun 18, 2024
lucaspin
reviewed
Jun 18, 2024
lucaspin
reviewed
Jun 18, 2024
lucaspin
reviewed
Jun 18, 2024
hamir-suspect
force-pushed
the
has/secrets-content-removed
branch
from
edcf6f9
to
8612b68
Compare
hamir-suspect
force-pushed
the
has/secrets-content-removed
branch
from
8612b68
to
e240283
Compare
lucaspin
reviewed
Jun 18, 2024
lucaspin
reviewed
Jun 18, 2024
lucaspin
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://github.com/renderedtext/project-tasks/issues/1284