Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard - event.object_name incorrect #214

Closed
bcorijn opened this issue Nov 2, 2016 · 1 comment
Closed

Dashboard - event.object_name incorrect #214

bcorijn opened this issue Nov 2, 2016 · 1 comment
Labels

Comments

@bcorijn
Copy link

bcorijn commented Nov 2, 2016

I seem to be bothering you with quite some issues/questions, but here's another one I noticed:

When checking the global dashboard or a project dashboard, the event.object_name seems to be incorrectly loaded. I would expect it to show the playbook name of the task that the event it is related to, instead it is showing the playbook name of the oldest task available in the history. It thus also shows the same object_name for every event in the dashboard.

Digging into the code it looks like this query is to blame: https://github.com/ansible-semaphore/semaphore/blob/master/api/events.go#L44-L46. It does not take into account the event.object_id or the fact that the task might get deleted while the event remains.

@matejkramny
Copy link
Contributor

Thanks, no bother at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants