Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

print number of rules being run if using web ui #138

Merged
merged 3 commits into from
Dec 17, 2020
Merged

print number of rules being run if using web ui #138

merged 3 commits into from
Dec 17, 2020

Conversation

chmccreery
Copy link
Contributor

@chmccreery chmccreery commented Dec 16, 2020 •
edited
Loading

  • Gives a user confidence in which rules (and how many rules) ran on a given scan
  • Since policy name is printed here as well, it is easy to go to the semgrep-app for details
  • helps to alert user that something is wrong (num_rules is 0 or is way larger than expected)

closes https://github.com/returntocorp/semgrep-action/issues/130
Screen Shot 2020-12-15 at 4 46 32 PM

@cla-bot cla-bot bot added the cla-signed label Dec 16, 2020
@chmccreery chmccreery merged commit c41a804 into develop Dec 17, 2020
@chmccreery chmccreery deleted the cm/print-num-rules branch December 17, 2020 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@underyx underyx underyx approved these changes

@nbrahms nbrahms Awaiting requested review from nbrahms

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semgrep action indicates how many rules ran on a scan
2 participants
@chmccreery @underyx