Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to fix bugs, add links, and update structure #3371

Merged
merged 8 commits into from
May 8, 2024

Conversation

pabloest
Copy link
Member

@pabloest pabloest commented May 3, 2024

No description provided.

@pabloest pabloest requested a review from khorne3 May 3, 2024 20:05
@pabloest pabloest marked this pull request as ready for review May 3, 2024 20:05
Copy link
Contributor

@khorne3 khorne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pabloest and others added 6 commits May 6, 2024 08:50
Co-authored-by: Katie Horne <katie.horne@semgrep.com>
Co-authored-by: Katie Horne <katie.horne@semgrep.com>
Co-authored-by: Katie Horne <katie.horne@semgrep.com>
Co-authored-by: Katie Horne <katie.horne@semgrep.com>
Co-authored-by: Katie Horne <katie.horne@semgrep.com>
Co-authored-by: Katie Horne <katie.horne@semgrep.com>
@pabloest
Copy link
Member Author

pabloest commented May 6, 2024

Thanks for the review, @khorne3. I accepted your suggestions. Can you please check it again?

Copy link
Contributor

@khorne3 khorne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pabloest pabloest requested a review from khorne3 May 7, 2024 00:38
@pabloest
Copy link
Member Author

pabloest commented May 7, 2024

@khorne3 I think you have to re-enter your review in GH so I just re-requested that.

@pabloest pabloest enabled auto-merge May 7, 2024 00:38
Copy link
Contributor

@p4p3r p4p3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pabloest pabloest merged commit 6d94071 into develop May 8, 2024
8 checks passed
@pabloest pabloest deleted the pablo/readme-update branch May 8, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants