semipperm: resolve issue 817 #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
force-pushed
the
fix-issue-817
branch
from
85dff0d
to
afb72fe
Compare
The issue seems to have been caused by there being mismatch in the generators used in SmallerDegreePartialPermRepresentation, so that Factorization used too large indices
james-d-mitchell
force-pushed
the
fix-issue-817
branch
from
afb72fe
to
57638df
Compare
wilfwilson
approved these changes
May 25, 2022
| @@ -242,7 +242,7 @@ function(S) | |||
| sigmainv, enum, orbits, cosets, stabpp, psi, rho, rhoinv, stab, nrcosets, j, | |||
| reps, gen, offset, rep, box, subbox, T, map, inv, d, k, i, m; | |||
|
|
|||
| oldgens := Generators(S); | |||
There was a problem hiding this comment.
Generators?! Death sentence!
There was a problem hiding this comment.
My thoughts exactly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue seems to have been caused by there being mismatch in the
generators used in
SmallerDegreePartialPermRepresentation, so thatFactorizationused too large indices