Resolve Issue #868 #872
Merged
Resolve Issue #868 #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
force-pushed
the
fix-issue-868
branch
from
fd61d2b
to
5e747c5
Compare
james-d-mitchell
force-pushed
the
fix-issue-868
branch
from
5e747c5
to
6b15ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the method for
MaximalDClassesforIsMonoidAsSemigroupassumed that the argument knew itsMultiplicativeNeutralElement, which isn't the case for monoids/semigroups defined by a multiplication table.