Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs!: create docs and readme. #217

Merged
merged 6 commits into from
Mar 26, 2024
Merged

docs!: create docs and readme. #217

merged 6 commits into from
Mar 26, 2024

Conversation

gusinacio
Copy link
Collaborator

@gusinacio gusinacio commented Mar 25, 2024 •
edited
Loading

update the modules for better visibility and documentation

Fixes TAP-182

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
docs!: create docs and readme.
4ebf258 
update the modules for better visibility and documentation

Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
test: fix integration test rav rpc
fe87ba2 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
style: cargo fmt
cfb5dcb 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8424328851

Details

  • 9 of 12 (75.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 78.809%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/receipt/state.rs 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
tap_core/src/receipt/checks.rs 1 76.81%
tap_core/src/rav/request.rs 1 0.0%
Totals Coverage Status
Change from base Build 8269039047: -0.5%
Covered Lines: 900
Relevant Lines: 1142
💛 - Coveralls

aasseman
aasseman requested changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

  • Just a few suggestions here and there
  • Could you also make sure all comments/docstrings lines are under 100 chars long? If you have more it tends to completely (and silently) break rustfmt on those files.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tap_core/src/rav.rs Outdated Show resolved Hide resolved
tap_core/src/rav.rs Outdated Show resolved Hide resolved
tap_core/src/rav.rs Outdated Show resolved Hide resolved
tap_core/src/signed_message.rs Outdated Show resolved Hide resolved
tap_core/src/signed_message.rs Outdated Show resolved Hide resolved
@gusinacio
docs: update requested changes
cba489f 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gusinacio
docs: use direct link to github for contributing guide
7f4f6cb 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio requested a review from aasseman March 25, 2024 23:44
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
aasseman
aasseman reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a couple more sorry 😬

tap_core/src/signed_message.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gusinacio
docs: update readme and signed_message
2a2117b 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio requested a review from aasseman March 26, 2024 13:36
@github-actions GitHub Actions
Copy link

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

@gusinacio gusinacio merged commit 1a1edf0 into main Mar 26, 2024
10 checks passed
@aasseman aasseman mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gusinacio @aasseman