-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs!: create docs and readme. #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
update the modules for better visibility and documentation Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
gusinacio
force-pushed
the
gusinacio/documentation
branch
from
March 25, 2024 17:25
e41bc9d
to
cfb5dcb
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 8424328851Details
💛 - Coveralls |
aasseman
suggested changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
- Just a few suggestions here and there
- Could you also make sure all comments/docstrings lines are under 100 chars long? If you have more it tends to completely (and silently) break
rustfmt
on those files.
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
gusinacio
force-pushed
the
gusinacio/documentation
branch
from
March 25, 2024 23:44
4f4d3fa
to
7f4f6cb
Compare
This comment has been minimized.
This comment has been minimized.
aasseman
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a couple more sorry 😬
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
🤖 Cargo Audit Report 🤖 (Empty means OK! 👍) |
aasseman
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the modules for better visibility and documentation
Fixes TAP-182