Small core fixes #798
Merged
Small core fixes #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyabrower
approved these changes
Oct 6, 2023
… douplicated call
msereniti
force-pushed
the
small-core-fixes
branch
from
92e1669
to
7b90c55
Compare
ilyabrower
pushed a commit
that referenced
this pull request
Oct 10, 2023
## Motivation and Context I found several issues. 1. BaseTrigger generates warnings about using non existing attribute. That would be better fixed after #748 but for now I just used the attribute name that is not passing _the grand regexp_. 2. If function is provided to ref prop, it will be called twice in deep nested components because assignProps were not clearing forwardRef prop after merging it into ref prop. 3. ScrollArea component remounts after first render. It caused by assignProp function that generates new ref function callback on every render. It cannot be fixed with current core and is not fixed in this PR. ## How has this been tested? All existing tests should pass. ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [ ] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [x] I have updated the documentation accordingly or it's not required. - [x] Unit tests are not broken. - [x] I have added changelog note to corresponding `CHANGELOG.md` file with planned publish date. - [ ] I have added new unit tests on added of fixed functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I found several issues.
How has this been tested?
All existing tests should pass.
Types of changes
Checklist:
CHANGELOG.mdfile with planned publish date.