JSON Serializer produces invalid JSON if a value ends with quote

[craigdietrich]

serializers/ARC2_RDFJSONSerializer.php->jsonEscape($v) begins by escaping the passed var using json_encode(). If the var is a string, the result will be a string wrapped by quotes. The function then removes these quotes using trim(),

if (function_exists('json_encode')) return trim(json_encode($v), '"');

However, if a string passed into the function ends with a quote, json_encode() will result in,

"This is a string "ending in a quote/""

trim() will then remove both quotes, resulting in,

This is a string "ending in a quote/

When this string is passed to the JSON output, the result is,

{
"example": "This is a string "ending in a quote/"
}

... where the errant slash at the end escapes the JSON ending quote, resulting in invalid JSON.

This is the update I've made locally, which explicitly removes a single quote from the beginning and end if they exist.

if (function_exists('json_encode')) { // Updated by Craig
$v = json_encode($v);
if ('"'==substr($v,0,1)&&'"'==substr($v,-1,1)) $v = substr($v, 1, -1);
return $v;
}

(Should probably use regex instead.)

Thanks!

[Knurg]

Thanks for this!

I fixed the issue in my repository. Please have a look at Knurg@5d9640f

Code:
if (function_exists('json_encode')) {
$v = json_encode($v);
if(preg_match('/^"(.*)"$/', $v, $matches))
$v = $matches[1];
return $v;
}

I hope this does what it should do.

[craigdietrich]

Hi Mark,

I've tested your code on my end and all looks well.

Thanks -- appreciated!

[semsol]

Thanks guys, fixed in the latest revision.