Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vi): maintenance vietnamese translation #350

Merged
merged 2 commits into from
Jul 25, 2022
Merged

fix(vi): maintenance vietnamese translation #350

merged 2 commits into from
Jul 25, 2022

Conversation

LaoshuBaby
Copy link
Contributor

@LaoshuBaby LaoshuBaby commented May 16, 2022 •
edited
Loading

  • fill missing vietnamese version index.md
  • change markdown meta key to English

Note: I can't speak Viernamese.

@JohnTitor
Copy link
Member

@Minh-neolab You originally wrote the Vietnamese translation, could you review this?

@LaoshuBaby
Copy link
Contributor Author

You originally wrote the Vietnamese translation, could you review this?

Note: This is only copy of current Vietnamese text, and Native speaker's review sounds well !

@JohnTitor JohnTitor closed this Jul 25, 2022
@JohnTitor JohnTitor reopened this Jul 25, 2022
JohnTitor
JohnTitor approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing & reviewing!

@JohnTitor JohnTitor merged commit 5bfed4b into semver:gh-pages Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M1nhNV M1nhNV M1nhNV approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
i18n Localization waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaoshuBaby @JohnTitor @M1nhNV