Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove retracted AST analyses retests #10

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR allows to remove previously retracted AST analyses with the AST panel view

Current behavior before PR

Previously retracted AST analyses retests are rendered as readonly, so that the checkboxes to deselect were disabled

Desired behavior after PR is merged

Retracted AST analyses retests are rendered as editable, so that the checkboxes can be deselected to remove the analysis

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa January 13, 2022 09:44
@ramonski ramonski added the bug Something isn't working label Jan 13, 2022
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@xispa xispa merged commit 07ceef0 into master Jan 13, 2022
@xispa xispa deleted the fix-removal-of-retracted-ast-analyses branch January 13, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants