Fix Sensitivity result is not updated when selective reporting is missing #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
xispa
changed the title
ramonski
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request guarantees the sensitivity result is correctly updated when no selective reporting analysis is set, either because the AST was added manually (via "Customize" option) or because the AST Panel selected had the option "Selective reporting" set to
False.The reason of why this was not working as expected is because the
calc_astcalculation was not returning the result to be set to the given analysis. Reason is that the calculation logic itself was updating the results already. When a selective reporting analysis was present, the last calculation to be called was bound to the reporting analysis itself and therefore, the results of the sensitivity were updated, and not overwritten by the calc machinery afterwards.Current behavior before PR
Sensitivity results are not updated (but cleared) when no selective reporting is set
Desired behavior after PR is merged
Sensitivity results are updated when no selective reporting is set, assuming that all results must be reported
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.