Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remarks rendering in reports #103

Merged
merged 3 commits into from Dec 7, 2020
Merged

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Dec 7, 2020

Description of the issue/feature this PR addresses

Linked issue: #99

Current behavior before PR

  • Remarks rendered as raw records structure
  • UnicodeDecode Error when the remarks content contains unicode chars (Error: 'ascii' codec can't decode byte 0xc3 in position 64: ordinal not in range(128))

Desired behavior after PR is merged

  • Remarks rendered similar as in samples
  • Unicode chars handled correctly

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

This fixes also unicode decode errors of remarks contents
@xispa xispa added the To port label Dec 7, 2020
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants