Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build is broken #70

Closed
vaskoz opened this issue Apr 6, 2018 · 0 comments · Fixed by #71
Closed

Build is broken #70

vaskoz opened this issue Apr 6, 2018 · 0 comments · Fixed by #71
Assignees
@vaskoz
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library

Comments

@vaskoz
Copy link
Contributor

vaskoz commented Apr 6, 2018 •
edited
Loading

Issue Summary

The build is broken right now. I completed the following fixes in individual commits.

* 96b32b0 2018-04-06 | fix godoc comments for some functions (HEAD -> fixBuild, vaskoz/fixBuild) [Vasko Zdravevski]
* 9968371 2018-04-06 | fix golint issue testingApi -> testingAPI [Vasko Zdravevski]
* 90ba74a 2018-04-06 | fix expected files in TestRepoFiles [Vasko Zdravevski]
* d88e957 2018-04-06 | update year to 2018 to fix TestLicenseYear [Vasko Zdravevski]
* 8430197 2018-04-06 | go fmt ./... formatting fixes [Vasko Zdravevski]
* ca669a4 2018-04-06 | fix gometalinter issue of an unchecked error [Vasko Zdravevski]
* e29d0ac 2018-04-06 | add go 1.10.x runtime to travis.yml [Vasko Zdravevski]

Steps to Reproduce

  1. Just check the TravisCI build.

Technical details:

  • Added Go 1.10 runtime for the travis ci build.
@vaskoz vaskoz self-assigned this Apr 6, 2018
@vaskoz vaskoz mentioned this issue Apr 6, 2018
Merged
6 tasks
@thinkingserious thinkingserious added type: bug bug in the library status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty labels Apr 9, 2018
thinkingserious added a commit that referenced this issue Apr 9, 2018
@thinkingserious
Version Bump v2.4.1: Pull #71, Solves #70: Fix Travis CI Build
306b9be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaskoz vaskoz

Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build vaskoz/rest
2 participants
@vaskoz @thinkingserious