Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TROUBLESHOOTING #25

Merged
merged 2 commits into from
Oct 22, 2017
Merged

Added TROUBLESHOOTING #25

merged 2 commits into from
Oct 22, 2017

Conversation

alimasyhur
Copy link
Contributor

Added troubleshooting while debuging request body.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 18, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 18, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alimasyhur alimasyhur mentioned this pull request Oct 18, 2017
Closed
mbernier
mbernier reviewed Oct 21, 2017
View reviewed changes
Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkingserious since rest_test.go also changed, can you please double check this one?

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 22, 2017
@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 22, 2017
@mbernier mbernier merged commit ee153a7 into sendgrid:master Oct 22, 2017
@thinkingserious
Copy link
Contributor

Hello @alimasyhur,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@alimasyhur
Copy link
Contributor Author

Thank you SendGrid DX.
I filled that form out,

Regards, Ali

@mbernier
Copy link
Contributor

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbernier mbernier mbernier left review comments

@thinkingserious thinkingserious Awaiting requested review from thinkingserious

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alimasyhur @SendGridDX @thinkingserious @mbernier