Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .md files for SEO-ness #28

Merged
merged 2 commits into from
Oct 22, 2017
Merged

Update .md files for SEO-ness #28

merged 2 commits into from
Oct 22, 2017

Conversation

liamrosenfeld
Copy link
Contributor

@liamrosenfeld liamrosenfeld commented Oct 20, 2017

_ replaced with -

@mbernier edit: closes #26

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 20, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 20, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change for rest-test to rest_test or change the file name :)

CONTRIBUTING.md Outdated
@@ -108,17 +108,17 @@ The main function that does the heavy lifting (and external entry point) is `API

All PRs require passing tests before the PR will be reviewed.

All test files are in [`rest_test.go`](https://github.com/sendgrid/rest/blob/master/rest_test.go).
All test files are in [`rest-test.go`](https://github.com/sendgrid/rest/blob/master/rest-test.go).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one didn't change, can you please change it back or change the file path itself?

CONTRIBUTING.md Outdated
@@ -51,9 +51,9 @@ Before you decide to create a new issue, please try the following:

### Please use our Bug Report Template

In order to make the process easier, we've included a [sample bug report template](https://github.com/sendgrid/rest/.github/ISSUE_TEMPLATE) (borrowed from [Ghost](https://github.com/TryGhost/Ghost/)). The template uses [GitHub flavored markdown](https://help.github.com/articles/github-flavored-markdown/) for formatting.
In order to make the process easier, we've included a [sample bug report template](https://github.com/sendgrid/rest/.github/ISSUE-TEMPLATE) (borrowed from [Ghost](https://github.com/TryGhost/Ghost/)). The template uses [GitHub flavored markdown](https://help.github.com/articles/github-flavored-markdown/) for formatting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks like there's one more small change. Sorry I didn't see this earlier!!

@liamrosenfeld
Copy link
Contributor Author

@mbernier, I fixed those mistakes.

@mbernier mbernier merged commit 360af62 into sendgrid:master Oct 22, 2017
@thinkingserious
Copy link
Contributor

Hello @liamrosenfeld,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .md files for SEO-ness
4 participants