Update .md files for SEO-ness #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
mbernier
suggested changes
Oct 21, 2017
CONTRIBUTING.md
Outdated
| @@ -108,17 +108,17 @@ The main function that does the heavy lifting (and external entry point) is `API | |||
|
|
|||
| All PRs require passing tests before the PR will be reviewed. | |||
|
|
|||
| All test files are in [`rest_test.go`](https://github.com/sendgrid/rest/blob/master/rest_test.go). | |||
| All test files are in [`rest-test.go`](https://github.com/sendgrid/rest/blob/master/rest-test.go). | |||
There was a problem hiding this comment.
This one didn't change, can you please change it back or change the file path itself?
mbernier
suggested changes
Oct 21, 2017
CONTRIBUTING.md
Outdated
| @@ -51,9 +51,9 @@ Before you decide to create a new issue, please try the following: | |||
|
|
|||
| ### Please use our Bug Report Template | |||
|
|
|||
| In order to make the process easier, we've included a [sample bug report template](https://github.com/sendgrid/rest/.github/ISSUE_TEMPLATE) (borrowed from [Ghost](https://github.com/TryGhost/Ghost/)). The template uses [GitHub flavored markdown](https://help.github.com/articles/github-flavored-markdown/) for formatting. | |||
| In order to make the process easier, we've included a [sample bug report template](https://github.com/sendgrid/rest/.github/ISSUE-TEMPLATE) (borrowed from [Ghost](https://github.com/TryGhost/Ghost/)). The template uses [GitHub flavored markdown](https://help.github.com/articles/github-flavored-markdown/) for formatting. | |||
There was a problem hiding this comment.
Hey, looks like there's one more small change. Sorry I didn't see this earlier!!
|
@mbernier, I fixed those mistakes. |
mbernier
approved these changes
Oct 22, 2017
|
Hello @liamrosenfeld, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ replaced with -
@mbernier edit: closes #26