Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration tests to utilize StopLight.io's Prism version v2.X #778

Closed
wants to merge 6 commits into from
Closed

Update integration tests to utilize StopLight.io's Prism version v2.X #778

wants to merge 6 commits into from

Conversation

tony-ho
Copy link
Contributor

@tony-ho tony-ho commented Oct 11, 2018

Fixes

Fixes #749
Fixes #648

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update Travis CI configuration to run Prism using Docker image
  • Add Docker Compose configuration to run Prism and the tests locally as a multi-container Docker application
  • Update the testing instructions to run Prism locally using the Docker image instead of downloading and installing Prism
  • Add HttpCompletionOption.ResponseHeadersRead in HttpClient.SendAsync() call to prevent content length exceptions when API returns empty response (fixes failing tests)
  • Fix incorrect endpoints calling Spam Reports API as per: GET /suppression/spam_report/{email} call not working / returning 404 sendgrid-php#354 (fixes failing tests)

@tony-ho
Run Prism in Travis CI using Docker image
25d6d83 
As per: https://docs.stoplight.io/testing/continuous-integration/travis
@tony-ho
Run tests as a multi-container Docker application
c274c73 
Remove logic to start/shutdown Prism from IntegrationFixture.
Add PRISM_URL environment variable to pass Prism URL to integration tests.
Add Dockerfile to build project and execute tests based on: https://github.com/dotnet/dotnet-docker/blob/master/samples/dotnetapp/Dockerfile
Add docker-compose.yml to start Prism and test runner containers.
@tony-ho
Prevent content length exceptions when API returns empty response
a546784 
Add HttpCompletionOption.ResponseHeadersRead in HttpClient.SendAsync() call.

Fixes #648
@tony-ho
Fix incorrect endpoints calling Spam Reports API
ae1a5c6 
See: sendgrid/sendgrid-php#354 (comment)
@tony-ho
Update testing instructions
3932fbe
@tony-ho
Remove obseleted Prism/Docker resources
fa25660
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2018
@devchas devchas added hacktoberfest difficulty: medium fix is medium in difficulty difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 11, 2018
@thinkingserious thinkingserious added status: hacktoberfest approved and removed difficulty: medium fix is medium in difficulty labels Nov 2, 2018
@thinkingserious thinkingserious added type: bug bug in the library and removed type: twilio enhancement feature request on Twilio's roadmap labels Jun 3, 2019
@childish-sambino
Copy link
Contributor

Closing as prism integration has been moved to https://github.com/sendgrid/sendgrid-oai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Milestone
No milestone
4 participants
@tony-ho @childish-sambino @thinkingserious @devchas