-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerize #137
Add Dockerize #137
Conversation
@dhoeric @SendGridDX hello guys, with last docker update multi staging docker file is available. I think this can help to reduce the size of container |
@zhikiri Thanks for your input. |
@dhoeric well, I think you're right :) It can live without multi staging dockerfile. |
docker/README.md
Outdated
) | ||
|
||
func main() { | ||
api_key := "JUST_A_TEST_KEY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having the key embedded in the script, could you have it pull from an environment variable that is loaded into the docker via a docker-compose file?
This would also allow you to have a "volume" param that would keep the source local for development purposes!
@mbernier thanks for your comment, the code is updated, feel free to review! |
OMG this is awesome! I really like how you set this up, thank you! @thinkingserious check this out. |
For #124
Added some examples for demo as well.
Please let me know if anything needed to be updated.
@mbernier edit: resolves #124