Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerize #137

Merged
merged 4 commits into from
Oct 30, 2017
Merged

Add Dockerize #137

merged 4 commits into from
Oct 30, 2017

Conversation

dhoeric
Copy link
Contributor

@dhoeric dhoeric commented Oct 5, 2017

For #124

Added some examples for demo as well.
Please let me know if anything needed to be updated.

@mbernier edit: resolves #124

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 5, 2017

CLA assistant check
All committers have signed the CLA.

@kyl0b1te
Copy link

kyl0b1te commented Oct 7, 2017

@dhoeric @SendGridDX hello guys, with last docker update multi staging docker file is available. I think this can help to reduce the size of container

@dhoeric
Copy link
Contributor Author

dhoeric commented Oct 7, 2017

@zhikiri Thanks for your input.
But this image requiring a go runtime to compile user's .go for testing, may not be suitable to take off in this use case?

@kyl0b1te
Copy link

@dhoeric well, I think you're right :) It can live without multi staging dockerfile.

docker/README.md Outdated
)

func main() {
api_key := "JUST_A_TEST_KEY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than having the key embedded in the script, could you have it pull from an environment variable that is loaded into the docker via a docker-compose file?

This would also allow you to have a "volume" param that would keep the source local for development purposes!

@dhoeric
Copy link
Contributor Author

dhoeric commented Oct 29, 2017

@mbernier thanks for your comment, the code is updated, feel free to review!

@mbernier
Copy link
Contributor

OMG this is awesome! I really like how you set this up, thank you!

@thinkingserious check this out.

@mbernier mbernier merged commit c5f4bb4 into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Contributor

Hello @dhoeric,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize
5 participants