Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break the testing class apart :: test/unit/SendGridTest.php #540

Closed
thinkingserious opened this issue Oct 30, 2017 · 4 comments · Fixed by #543
Closed

Break the testing class apart :: test/unit/SendGridTest.php #540

thinkingserious opened this issue Oct 30, 2017 · 4 comments · Fixed by #543

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 30, 2017

All our tests are in one class. Break them up by type and use a base test class.

Make sure all the tests still run and report the same way as before.

https://codeclimate.com/github/sendgrid/sendgrid-php/test/unit/SendGridTest.php#issue_59f668408905d74fee00001e

@mbernier mbernier changed the title Fix "" issue in test/unit/SendGridTest.php Break the testing class apart :: test/unit/SendGridTest.php Oct 30, 2017
@owenvoke
Copy link
Contributor

Not claiming, but I'm happy to have a look at this. 👍

@owenvoke
Copy link
Contributor

I'm working on this in feature/split-unit-tests but for some reason I keep getting this error in Prism:
error modifying response: via: detected request loop, header contains prism

I'll continue working later when I'm on a native Linux OS, rather than LSFW at work.

@owenvoke
Copy link
Contributor

owenvoke commented Oct 30, 2017

To be honest, just seem to be getting quite a few issues with the Prism binary. 🤔

I've done all the tests though. I may tidy up the structure though (which I've started with a few of them).

Looks like it's just the way it initializes the Prism binary at the start. So I will investigate this and try to get it working.

@owenvoke
Copy link
Contributor

owenvoke commented Oct 30, 2017

Ok, never mind. Looks like the test suite requires v1.5.0 of Prism, but the PHP installer in the test suite will download the latest version (2.0.0-beta.2) which doesn't work with the OAI specification JSON.

Once I'd installed v1.5.0 it worked. I'll make a PR shortly once I've tidied up some things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants