Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/split unit tests #543

Merged
merged 75 commits into from
Dec 21, 2017
Merged

Conversation

owenvoke
Copy link
Contributor

Fixes #540

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Travis tests

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@owenvoke
Copy link
Contributor Author

owenvoke commented Oct 31, 2017

Well, Travis failed. They seem to be having issues recently. 😕

https://www.traviscistatus.com/incidents/xgpn2tq6mx7k

This one I can't resolve as I'm not able to restart the Travis job.

@mbernier
Copy link

I just kicked it over, we will see what Travis says here in a bit!

@owenvoke
Copy link
Contributor Author

Well... that definitely didn't work. 😋

I'll have a look a bit later when I get off work, and see if I can get it working again.

The Composer autoloader does the equivalent of this anyway.
@owenvoke
Copy link
Contributor Author

This seems to all be working, except for one test.

It looks like this test has never passed though.
https://github.com/sendgrid/sendgrid-php/commits/master/test/unit/FilesExistTest.php

@thinkingserious
Copy link
Contributor

No worries @pxgamer, that test is expected to fail at the moment.

This PR has been added to our backlog for review, thanks!

@mbernier
Copy link

We are good to go, thank you @pxgamer!!

@mbernier mbernier merged commit 056e5a6 into sendgrid:master Dec 21, 2017
@thinkingserious
Copy link
Contributor

Hello @pxgamer,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@owenvoke owenvoke deleted the feature/split-unit-tests branch December 22, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break the testing class apart :: test/unit/SendGridTest.php
4 participants