Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor typo during Mail creation #431

Merged
merged 1 commit into from
Sep 23, 2017

Conversation

joeldixon66
Copy link
Contributor

I think you had a very small typo in one of the examples (adding $to instead of the ToCollection $tos).

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 21, 2017
@SendGridDX
Copy link

SendGridDX commented Sep 21, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @joeldixon66!

Did you have any other feedback on the new prototype? We are looking for at least one more thumbs up so that we may begin development.

With Best Regards,

Elmer

@joeldixon66
Copy link
Contributor Author

No worries @thinkingserious - I'm happy with the new prototype - but I'm new to SendGrid and the php client - so I'm certainly not any authority on the matter. I'm still happy to provide a yes vote if you'd like.

@thinkingserious
Copy link
Contributor

Hi @joeldixon66,

Your feedback is still very valuable. It is good to get an objective opinion from someone outside the SendGrid ecosystem, but that has experience with PHP.

Thanks!

With Best Regards,

Elmer

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 23, 2017
@thinkingserious thinkingserious merged commit dab4dd9 into sendgrid:master Sep 23, 2017
@thinkingserious
Copy link
Contributor

Hello @joeldixon66,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants