Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set attachment content from path #493

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Set attachment content from path #493

merged 1 commit into from
Mar 28, 2018

Conversation

rparpa
Copy link
Contributor

@rparpa rparpa commented Oct 17, 2017

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 17, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 24, 2017
@mbernier
Copy link

mbernier commented Nov 3, 2017

@rparpa

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added the type: twilio enhancement feature request on Twilio's roadmap label Feb 28, 2018
@thinkingserious
Copy link
Contributor

Hello @rparpa,

Could you please fix the merge conflicts so that I may complete the code review? Thanks!

With Best Regards,

Elmer

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Mar 28, 2018
@rparpa
Copy link
Contributor Author

rparpa commented Mar 28, 2018

Hello @thinkingserious

It's done, you should be able to review now.

Rémi

@thinkingserious thinkingserious merged commit 25e3894 into sendgrid:master Mar 28, 2018
@thinkingserious
Copy link
Contributor

Hello @rparpa,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rparpa @SendGridDX @mbernier @thinkingserious @apigirl