Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for: Remove unnecessary linter warning from phpcs #628

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

hjmsw
Copy link
Contributor

@hjmsw hjmsw commented Jun 21, 2018

Fixes #610

There would seem to be a couple of possible fixes:

phpcs.xml file included in this pull request includes the PSR2 ruleset from: https://github.com/squizlabs/PHP_CodeSniffer/blob/master/src/Standards/PSR2/ruleset.xml

The whitespace at the end of lines rule has been removed. Not sure whether to include this or not but with this rule in place there are a huge number of whitespace errors. Please see gist of phpcs output: https://gist.github.com/hjmsw/aa5e0608fa38acaeb9c5a6f6a1aa788d

And without whitespace at end of line rule, another gist:
https://gist.github.com/hjmsw/2ac4f13a0b92dad296369481d0cf872e

Another alternative would be to use the --standard=PSR2 command switch when running phpcs. The rules wanting to be ignored in #610 were ignored when I ran with the above command switch.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 21, 2018
@thinkingserious
Copy link
Contributor

Thanks @hjmsw! I've added this to our backlog for review.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty labels Aug 6, 2018
@thinkingserious thinkingserious merged commit 3590a6f into sendgrid:master Aug 6, 2018
@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary linter warning from phpcs
2 participants