Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #663

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Update CONTRIBUTING.md #663

merged 1 commit into from
Aug 13, 2018

Conversation

af4ro
Copy link
Contributor

@af4ro af4ro commented Aug 10, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@af4ro af4ro added type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy labels Aug 10, 2018
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 10, 2018
@af4ro af4ro removed the status: code review request requesting a community code review or review from Twilio label Aug 10, 2018
@thinkingserious thinkingserious merged commit 73b7582 into master Aug 13, 2018
@thinkingserious
Copy link
Contributor

Hello @af4ro,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino deleted the af4ro-patch-2-1 branch January 8, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@af4ro @thinkingserious