Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prism version. Fixes #690 #698

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Update prism version. Fixes #690 #698

merged 2 commits into from
Oct 3, 2018

Conversation

geryjuhasz
Copy link
Contributor

@geryjuhasz geryjuhasz commented Oct 2, 2018 •
edited by thinkingserious
Loading

Fixes #690

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
@geryjuhasz geryjuhasz mentioned this pull request Oct 2, 2018
Closed
@thinkingserious thinkingserious added hacktoberfest difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy labels Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @geryjuhasz,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious removed the status: code review request requesting a community code review or review from Twilio label Oct 3, 2018
@thinkingserious thinkingserious merged commit 62a985c into sendgrid:master Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @geryjuhasz,

Thanks again for the PR!

You have earned 7 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update integration tests to utilize StopLight.io's Prism version v2.X
2 participants
@geryjuhasz @thinkingserious