Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is failing in #348 #400

Merged
merged 1 commit into from
Oct 20, 2017
Merged

This is failing in #348 #400

merged 1 commit into from
Oct 20, 2017

Conversation

mbernier
Copy link
Contributor

@mbernier mbernier commented Oct 19, 2017 •
edited
Loading

My guess is this should be one line?

I saw a failure in #348 and looked at this file, it is broken to two lines and I am wondering if this is causing the failure I am seeing?

This is failing in #348
e784175 
My guess is this should be one line?
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 19, 2017
@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 19, 2017
@thinkingserious thinkingserious merged commit 75ccf42 into master Oct 20, 2017
@thinkingserious
Copy link
Contributor

Hello @mbernier,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious deleted the mbernier-patch-2 branch September 11, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbernier @thinkingserious