Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary require statements #337

Conversation

moutten
Copy link
Contributor

@moutten moutten commented Oct 10, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • N/A [ ] I have added tests that prove my fix is effective or that my feature works
  • N/A [ ] I have added necessary documentation about the functionality in the appropriate .md file
  • N/A [ ] I have added in line documentation to the code I modified

Short description of what this PR does:

Because none of these files use the JSON library, it's not necessary
to use require 'json' at the beginning of the files. This is only a
minor cleanup but using more require statements does have the
potential to slow down applications when more gems are installed and
the include path grows within Ruby.

Because none of these files use the JSON library, it's not necessary
to use `require 'json'` at the beginning of the files. This is only a
minor cleanup but using more `require` statements does have the
potential to slow down applications when more gems are installed and
the include path grows within Ruby.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 10, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 10, 2018

CLA assistant check
All committers have signed the CLA.

@childish-sambino childish-sambino changed the title Remove unnecessary require statements chore: Remove unnecessary require statements Mar 6, 2020
@childish-sambino childish-sambino merged commit 2c78ac5 into sendgrid:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants