Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate(typescript): [WIP] Shifting codebase to Typescript #59

Closed

Conversation

rishabh3112
Copy link
Contributor

Migrating whole plugin to .ts

@sendilkumarn
Copy link
Owner

The build is failed due to some network flakiness in the Circle CI.

@rishabh3112
Copy link
Contributor Author

Waiting for webpack/webpack-cli#577 and webpack/webpack-cli#577 to resolve which will certainly solve the remaining errors rest work done 😉✌

@rishabh3112 rishabh3112 changed the title [WIP] Typescript support migrate(typescript): [WIP] Shifting codebase to Typescript Sep 4, 2018
@rishabh3112
Copy link
Contributor Author

The scaffold isn't working as of now so don't merge it @sendilkumarn
error encountered is sent on Slack

@sendilkumarn
Copy link
Owner

@rishabh3112 Do you still have the error?

@rishabh3112
Copy link
Contributor Author

Its mergeable and work great but entry point of plugin would be in javascript @sendilkumarn

@sendilkumarn
Copy link
Owner

There is a merge conflict, can you fix it?

The entry point will be in JavaScript

Is it because of yeoman?

@rishabh3112
Copy link
Contributor Author

rishabh3112 commented Sep 11, 2018

There is a merge conflict, can you fix it?

Would be able to do within 3-4 days as I have my laptop shut right now.

If you are free it would be awesome!!

Is it because of yeoman?

Checkout slack
@sendilkumarn

@sendilkumarn sendilkumarn mentioned this pull request Sep 15, 2018
@sendilkumarn
Copy link
Owner

closing in favor of #63

@rishabh3112 rishabh3112 mentioned this pull request Sep 16, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants