Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct small bug in sa_via_window function #6

Closed
wants to merge 1 commit into from

Conversation

misilva73
Copy link

In the current code, the for loop does not include the last observation of the time series, i.e., it stops one window too early. Thus, you need to add the '+1' so that the range function includes the last observation.

In the current code, the for loop does not include the last observation of the time series, i.e., it stops one window too early. Thus, you need to add the '+1' so that the range function includes the last observation.
@seninp
Copy link
Owner

seninp commented Feb 29, 2020

Thanks! It has been fixed!

@seninp seninp closed this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants