Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multidimensional SAX (and fixes to HOT-SAX) #8

Merged
merged 70 commits into from
Feb 29, 2020
Merged

Conversation

ameya98
Copy link
Contributor

@ameya98 ameya98 commented May 31, 2019

Implements extensions to multi-dimensional SAX via SAX-ZSCORE and SAX-REPEAT from Robust learning from demonstrations using multidimensional SAX, as well as a new method SAX-ENERGY (that performs SAX along the data-dimensions). Fixes off-by-one errors in HOT-SAX, sax_by_window and the brute force method for discords. Further, reimplements VisitRegistry as a set.

Ameya Daigavane added 30 commits May 28, 2019 15:58
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #8 into master will decrease coverage by 11.44%.
The diff coverage is 65.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
- Coverage   86.68%   75.24%   -11.45%     
===========================================
  Files          12       12               
  Lines         338      412       +74     
===========================================
+ Hits          293      310       +17     
- Misses         45      102       +57
Impacted Files Coverage Δ
saxpy/discord.py 100% <100%> (ø) ⬆️
saxpy/hotsax.py 100% <100%> (ø) ⬆️
saxpy/visit_registry.py 100% <100%> (ø) ⬆️
saxpy/distance.py 100% <100%> (ø) ⬆️
saxpy/sax.py 53.7% <36.7%> (-46.3%) ⬇️
saxpy/znorm.py 77.27% <75%> (-22.73%) ⬇️
saxpy/paa.py 92.59% <91.3%> (-7.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0620017...5dea46b. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files          12       12           
  Lines         423      423           
=======================================
  Hits          372      372           
  Misses         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b23f42...c30a657. Read the comment docs.

@ameya98
Copy link
Contributor Author

ameya98 commented May 31, 2019

Added doctests for coverage - should be okay now.

@ameya98
Copy link
Contributor Author

ameya98 commented Jun 8, 2019

I also added SAX-INDEPENDENT to sax_via_window(). This applies SAX independently to each dimension and concatenates the SAX words. Doctests have been written too, in sax_via_window().

@ameya98
Copy link
Contributor Author

ameya98 commented Jun 20, 2019

The current HOT-SAX implementation is quite inefficient - both the SAX words and the znormalized subsequences only need to be computed once. I've improved HOT-SAX by making these changes. Runtime performance is now better by 10x-20x.

@seninp seninp merged commit 6781b39 into seninp:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants